Skip to content

Reorder start() and subscribe() for possible thread race#404

Merged
cogmission merged 1 commit intonumenta:masterfrom
cogmission:openjdk_experiment
Mar 26, 2016
Merged

Reorder start() and subscribe() for possible thread race#404
cogmission merged 1 commit intonumenta:masterfrom
cogmission:openjdk_experiment

Conversation

@cogmission
Copy link
Copy Markdown
Collaborator

Fixes #403

Hopefully... I don't have OpenJDK, but I highly suspect the following changes will solve this.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.694% when pulling 22c175b on cogmission:openjdk_experiment into 84f998c on numenta:master.

@cogmission
Copy link
Copy Markdown
Collaborator Author

@rhyolight No new changes, no new code. Just reordered 2 statements in 4 or 5 tests is about all... So I want to merge this so that @EronWright can test this tomorrow.

@cogmission cogmission merged commit 43abaf6 into numenta:master Mar 26, 2016
@EronWright
Copy link
Copy Markdown
Contributor

Would you mind trying the docker-based build PR? It would be nice for someone to give it a try.

@cogmission
Copy link
Copy Markdown
Collaborator Author

@EronWright Ok, installed Docker, and went through their tutorial, installed your Dockerfile and tested this new code. (It didn't fix the problem)

So now I want to start eclipse from within a Docker image so I can run and debug using OpenJDK (isolated from the rest of my system and environment because I really don't have time to mess with that and finish Serialization)

Do you know how to setup Docker so I can run Eclipse from within that environment so I can solve this OpenJDK issue?

@cogmission
Copy link
Copy Markdown
Collaborator Author

@EronWright Your instructions were great! BTW I had no problem following along...

@cogmission
Copy link
Copy Markdown
Collaborator Author

I think I found a way to install Eclipse under docker... https://github.com/fgrehm/docker-eclipse

@EronWright
Copy link
Copy Markdown
Contributor

An alternative is to use remote debugging, by running the container with -p 5005:5005, running gradle with the debugger on, and attaching to the address returned by docker-machine ip default.

I will do that later today, and update the doc with better instructions.

@cogmission cogmission deleted the openjdk_experiment branch July 23, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants